search

djyde / cusdis

lightweight, privacy-friendly alternative to Disqus.
https://cusdis.com
GNU General Public License v3.0
2.64k stars 232 forks source link

react-cusdis not supporting react v18 #245

Open ansharora28 opened 1 year ago

ansharora28 commented 1 year ago

I am able to install the dependencies and run the react app on my system. But react-cusdis seems to only work at ^17.0.0.0 so im not able to deploy my website since it fails to install dependencies during the build stage. Am i missing something?

DannySu09 commented 1 year ago

I use both React@18.2.0 and react-cusdis in my website and it works fine. Maybe it's not because of the version? Can you paste here the errors that occur during the dependencies installation?

greatzh commented 1 year ago

The same problem occurred when I installed the Cusdis, the error report shows that

# npm resolution error report

While resolving: rambles@0.1.0
Found: react@18.2.0
node_modules/react
  react@"^18.2.0" from the root project

Could not resolve dependency:
peer react@"^17.0.0" from react-cusdis@2.1.3
node_modules/react-cusdis
  react-cusdis@"*" from the root project

Fix the upstream dependency conflict, or retry
this command with --force or --legacy-peer-deps
to accept an incorrect (and potentially broken) dependency resolution.

should I install this with --force ?

nareshpingale commented 5 months ago

Raised a PR for adding reactv18 support to the react-cudis. Found reference to this repo from the official documentation. https://github.com/Cusdis/sdk/pull/10