search

dk / PDL-Drawing-Prima

Low-level PDL-threaded interface to the Prima drawing commands.
5 stars 4 forks source link

Change to PDL's PDL_INCLUDE breaks P::D::P build for PDL 2.008 #30

Closed d-lamb closed 9 years ago

d-lamb commented 9 years ago

Hi David

Because of this commit (see Basic/Core/Dev.pm) to be part of PDL-2.008, http://sourceforge.net/p/pdl/code/ci/d7172dcfa2da412e5e28894a9df96ec602adc7ac/ PDL-Drawing-Prima does not build (on my OS X Yosemite compiling with clang) because it can not find pdl.h. This is because the location of pdl.h is -Included with double quotes now:

-I"/Users/derek/local/lib.../PDL/Core" instead of -I/Users/derek/....PDL/Core

You can fix this in Build.PL by adding another regex after the the first '$inc =~ s/-I//g;'

$inc =~ s/\"//g;

Sorry this is not a pull request. Seemed silly to fork and pull request for a one-line change.

run4flat commented 9 years ago

Hey Derek, thanks for reporting this. I added a line that should fix this, I believe.

In the future, when you have a one-line fix like that, github has an interface that lets you edit the file in your browser and create a fork in your own account. You don't even need to pull the repository to your own machine and create your own fork.

fantasma13 commented 9 years ago

Hi David,

I have exactly this issue in v0.10. Did you (not) release the fix by any chance? Ingo

run4flat commented 9 years ago

No, I've not released it yet. I've been meaning to test things out before pushing the latest version to CPAN. I'll try to get to that soon, maybe today.

devel-chm commented 8 years ago

Was this fixed code released? I just tried to install PDL-Drawing-Prima-0.10 and had the same egregious extra "s leading to the build failure. Hand correcting in the _build folder to remove the extra quotes allowed the build to complete.

fantasma13 commented 8 years ago

No, it's not released yet, unfortunately. That means manual editing Build.PL whenever you need to install.

devel-chm commented 8 years ago

It would be nice if PDL::Graphics::Prima could be working for the upcoming PDL-2.014 release?

On Mon, Sep 28, 2015 at 8:16 AM, fantasma13 notifications@github.com wrote:

No, it's not released yet, unfortunately. That means manual editing Build.PL whenever you need to install.

— Reply to this email directly or view it on GitHub https://github.com/run4flat/PDL-Drawing-Prima/issues/30#issuecomment-143726948 .

run4flat commented 8 years ago

I have released the latest PDL::Drawing::Prima to CPAN. It seems to work fine for me, so I would appreciate any feedback on failures.

Thanks!

devel-chm commented 8 years ago

Yay, works out of the box on cygwin+PDL-2.014!

Thanks, Chris

On 11/8/2015 07:23, David Mertens wrote:

I have released the latest PDL::Drawing::Prima to CPAN. It seems to work fine for me, so I would appreciate any feedback on failures.

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/run4flat/PDL-Drawing-Prima/issues/30#issuecomment-154820308.