dk
commented
11 years ago Excellent work, thank you! Merged all right
/dk
On Wed, Jun 19, 2013 at 08:40:27AM -0700, run4flat wrote:
I've been looking closely at Prima::TextView for the last couple of weeks. I began working on revised documentation for Prima::TextView (not included in this patch) and in the process came across a handful of niggles and bugs. One bug is a series of warnings from PodView when and
=overblock is not followed by a distance, which I've silenced. The other is an issue with PodView's handling ofC<< $widget->method() >>which ends up getting rendered as if I had saidC<< $widget-method()> >>.This pull request solves these two bugs, makes a few parts of TextView a little more legible by using named variables in place of
$_, and adds a functioning Synopsis to TextView. You can merge this Pull Request by running:git pull https://github.com/run4flat/Prima fix-podview
Or you can view, comment on it, or merge it online at:
https://github.com/dk/Prima/pull/1
-- Commit Summary --
- Make recalcymap a bit more legible; remove direct assignment to $
- Use named iteration variables in TextView::on_paint
- Improved error return value handling in TextView's block_draw
- Added unexpected op handling via an else clause in TextView's block_draw
- Minor comment tweak
- Add SYNOPSIS to TextView
- Lightly cleaned up Prima::PodView::read_paragraph
- Added annotation to on_paint and revised erroneous else condition in block_draw
- Fix Prima::PodView's rendering of certain in-paragraph code blocks
-- File Changes --
M Prima/PodView.pm (19) M Prima/TextView.pm (71)-- Patch Links --
https://github.com/dk/Prima/pull/1.patch https://github.com/dk/Prima/pull/1.diff
Sincerely, Dmitry Karasik
I've been looking closely at Prima::TextView for the last couple of weeks. I began working on revised documentation for Prima::TextView (not included in this patch) and in the process came across a handful of niggles and bugs. One bug is a series of warnings from PodView when and
=overblock is not followed by a distance, which I've silenced. The other is an issue with PodView's handling ofC<< $widget->method() >>which ends up getting rendered as if I had saidC<< $widget-method()> >>.This pull request solves these two bugs, makes a few parts of TextView a little more legible by using named variables in place of
$_, and adds a functioning Synopsis to TextView.