New dev-release appears to not install, causing PDL downstream build of PDL::Drawing::Prima to fail

[dk]

Any details? This is a bit terse, and I couldn't observe the "not install"

[mohawk2]

This is not completed, and is still failing. See https://github.com/PDLPorters/pdl/actions/runs/5038087733/jobs/9035540043

An excerpt, which shows which version is failing, a warning, then the error which stops the build:

Building Prima-1.68_1
[...]
cc -c  -Iinclude -Iinclude/generic -I/usr/include/libpng16 -I/usr/include/x86_64-linux-gnu  -fopenmp -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -O2 -Wall   -DVERSION=\"1.68_1\" -DXS_VERSION=\"1.68_1\" -fPIC "-I/usr/local/lib/perl5/5.34.1/x86_64-linux-gnu/CORE"   class/Icon.c -o class/Icon.o
class/Icon.c: In function 'Icon_update_change':
class/Icon.c:188:21: warning: 'rgbcorners[0].b' may be used uninitialized in this function [-Wmaybe-uninitialized]
  188 |      ( rgbcorners[j]. b > 200))
      |        ~~~~~~~~~~~~~^~~
[...]
cc -c  -Iinclude -Iinclude/generic -I/usr/include/libpng16 -I/usr/include/x86_64-linux-gnu  -fopenmp -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -O2 -Wall   -DVERSION=\"1.68_1\" -DXS_VERSION=\"1.68_1\" -fPIC "-I/usr/local/lib/perl5/5.34.1/x86_64-linux-gnu/CORE"   unix/image.c -o unix/image.o
unix/image.c: In function 'img_render_argb_on_pixmap_or_widget':
unix/image.c:2012:9: warning: implicit declaration of function 'fallback' [-Wimplicit-function-declaration]
 2012 |  return fallback( self, image, req);
      |         ^~~~~~~~
unix/image.c: In function 'apc_gp_put_image':
unix/image.c:2458:18: error: 'PutImageRequest' has no member named 'dst_w'; did you mean 'dst_x'?
 2458 |  req.w     = req.dst_w = xLen;
      |                  ^~~~~
      |                  dst_x
unix/image.c:2459:18: error: 'PutImageRequest' has no member named 'dst_h'; did you mean 'dst_x'?
 2459 |  req.h     = req.dst_h = yLen;
      |                  ^~~~~
      |                  dst_x
unix/image.c: In function 'apc_image_begin_paint':
unix/image.c:2539:17: error: 'PutImageRequest' has no member named 'dst_w'; did you mean 'dst_x'?
 2539 |   req.w   = req.dst_w = img-> w;
      |                 ^~~~~
      |                 dst_x
unix/image.c:2540:17: error: 'PutImageRequest' has no member named 'dst_h'; did you mean 'dst_x'?
 2540 |   req.h   = req.dst_h = img-> h;
      |                 ^~~~~
      |                 dst_x
make: *** [Makefile:804: unix/image.o] Error 1

[mohawk2]

Also, it would be very helpful if you start tagging dev-releases (EDIT in fact, all releases), since the line-numbers on current master are now off and I don't know exactly where to look in the function on here.

[mohawk2]

It appears the dst_w etc are only defined in unix/image.c's PutImageRequest struct if HAVE_X11_EXTENSIONS_XRENDER_H is defined. If it is defined, the C code works. If not, obviously it won't.

[dk]

I see, thank you, fixed now!

[dk]

As for tagging I'm trying to be consistent with tagging normal releases, but I get to forget this for some reason. But can do the dev tagging, sure.