events Listing needs to be supported for JIRA incremental sync

dka23 / gitlab-github-proxy

Proxy to provide GitHub-like API on top of Gitlab. Especially designed to use the JIRA DVCS connector with Gitlab.

35 stars 19 forks source link

events Listing needs to be supported for JIRA incremental sync #9

Open dka23 opened 9 years ago

dka23 commented 9 years ago

When a hook is triggered from Gitlab, JIRA only seems to query the events endpoint for new events. Therefore this needs to be supported.

dka23 commented 9 years ago

The events API is quite large:

Therefore we should first check which information the DVCS connector needs and only return this information.

dka23 commented 9 years ago

Depending on the payload type, the DVCS connector uses different processors:

See https://bitbucket.org/atlassian/jira-dvcs-connector/src/0b8b97a247e2/jira-dvcs-connector-github/src/main/java/com/atlassian/jira/plugins/dvcs/spi/github/service/impl/?at=master
Payloads:
- IssueComment (obviously used for pull request comments) - getIssue().getPullRequest()
- PullRequest - getPullRequest()
- PullRequestReviewComment - search for existing comments in local repository
All payloads only trigger to a sync of the given pull request. Therefore only the getId() and the getNumber() is required.

dka23 commented 9 years ago

Exception now when syncing pull requests:

2015-10-02 15:19:40,958 http-bio-8090-exec-9 ERROR anonymous 919x108463x1 - 127.0.0.1 /rest/bitbucket/1.0/repository/110/sync [dvcs.sync.impl.DefaultSynchronizer] Cannot set non-null field GIT_HUB_ID to null java.lang.IllegalArgumentException: Cannot set non-null field GIT_HUB_ID to null ... at com.atlassian.jira.plugins.dvcs.service.GitHubEventServiceImpl.saveEventCounterpart(GitHubEventServiceImpl.java:239)

dka23 commented 9 years ago

Most likely due to the ID of the event being empty