search

dkahle / ggmap

A package for plotting maps in R with ggplot2
763 stars 231 forks source link

Issues with next version of ggplot2 #336

Closed thomasp85 closed 1 year ago

thomasp85 commented 1 year ago

Hi

We preparing the next release of ggplot2 and our reverse dependency checks show that your package is failing with the new version. Looking into it we see that your package somehow includes references to ggplot2 code from when it was build, which causes the check to emit the "Import not declared from..." error. Please see https://www.tidyverse.org/blog/2022/09/playing-on-the-same-team-as-your-dependecy/ for some more info about why this can cause issues.

You can install the release candidate of ggplot2 using devtools::install_github('tidyverse/ggplot2@v3.4.0-rc') to test this out.

We plan to submit ggplot2 by the end of October and hope you can have a fix ready before then

Kind regards Thomas

dkahle commented 1 year ago

Follow up. Ran revdepcheck, reached out to maintainers of (5) packages that it was unable to check. I suspect that the changes in ggmap don't affect them, however.