search

dkahle / ggmap

A package for plotting maps in R with ggplot2
766 stars 231 forks source link

Reflect that Stamen tiles are now hosted by Stadia Maps #350

Closed ianthetechie closed 11 months ago

ianthetechie commented 1 year ago

See http://maps.stamen.com/stadia-partnership/ and https://docs.stadiamaps.com/guides/migrating-from-stamen-map-tiles/.

This will probably be a semver breaking change regardless of any reorganization (since an API key will be required in the future). Additionally, the approach taken by Leaflet Providers, OpenLayers, etc. has been to change the source name while we're making breaking changes anyways.

I'll try to work up a PR myself and let you know if I get stuck; my R is a bit rusty ;)

ianthetechie commented 1 year ago

Quick bump on this for the project maintainers. We are still planning to start brownouts toward the end of September to let people know to switch over. It would be great to get ggmap updated ASAP since I assume many users and platforms have a longer update cycle.

Eric-Arellano commented 1 year ago

It would be great to get ggmap updated ASAP since I assume many users and platforms have a longer update cycle.

Indeed. We're using Shiny for https://parkingreform.org/mandates-map/ and are worried we won't be able to fix this in time. We've been migrating from Shiny to using Leaflet directly, which will avoid the problem. But we'd be in trouble if we hadn't already started the migration before this change to Stamen was announced.

ianthetechie commented 1 year ago

As a note to anyone finding this via a Google search wondering why their maps include warning tiles from Stamen, we have started serving brownout tiles infrequently in order to let developers know they have less than a month to upgrade. Hopefully the open PR can get merged soon.

ferrancarril commented 1 year ago

Hi! We're currently using get_stamenmap to include a heat map in some reports made with R. Since October 4th when generating our reports the pipeline sometimes fails on this step.

image

Is this related to brownout tiles? Is there any workaround for that until the PR is merged? This is some legacy project we're maintaining and I'm not an expert in R. Thank you.

ianthetechie commented 1 year ago

Hello @ferrancarril. I think this is probably related, but I unfortunately don't know the internals of the ggmap library that well.

We just updated our guide a few hours ago with details on how to install our patched version until the PR is merged. Let me know if you have any questions!

https://docs.stadiamaps.com/guides/migrating-from-stamen-map-tiles/#ggmap

ZacWarham commented 12 months ago

Hello @ferrancarril. I think this is probably related, but I unfortunately don't know the internals of the ggmap library that well.

We just updated our guide a few hours ago with details on how to install our patched version until the PR is merged. Let me know if you have any questions!

https://docs.stadiamaps.com/guides/migrating-from-stamen-map-tiles/#ggmap

I can confirm that @ferrancarril is related to the brownout of stamen_map and I have successfully been able to get it working using similar steps to what you provided above

The same problem is shown in https://github.com/dkahle/ggmap/issues/353