Updated get_stadiamap.R watercolor name to match new maptype name, stamen_watercolor

dkahle / ggmap

A package for plotting maps in R with ggplot2

766 stars 231 forks source link

Updated get_stadiamap.R watercolor name to match new maptype name, stamen_watercolor #357

Closed pushing-boulders closed 7 months ago

pushing-boulders commented 9 months ago

Before you open your PR

[x] Did you run R CMD CHECK?
[x] Did you run roxygen2::roxygenise(".")?

Description

Since the last update to address the hosting changes for Stamen tiles to Stadia Maps, the Stamen Water color style's maptype was changed from watercolor to stamen_watercolor in get_stadiamap.R.

When the filetype check occurs (line 306), the old name, watercolor, is still referenced. This pull request updates the name to stamen_watercolor.

Closes #356

tbrambor commented 7 months ago

@dkahle Can this be merged? Currently the watercolor map type is no longer accessible.

pushing-boulders commented 7 months ago

Hello @tbrambor. I agree. Not sure on the holdup.

You can make these modifications locally and the style will work again, just check the commit and make the edits if you are comfortable doing so.

dkahle commented 7 months ago

Got it, thanks @pushing-boulders, @tbrambor!

pushing-boulders commented 7 months ago

No problem @dkahle. Happy to help.