GIthub Actions - Githubissues

dkanada / frost

Icon Pack for Android Devices

GNU General Public License v3.0

163 stars 77 forks source link

GIthub Actions #273

Open ejiektpobehuk opened 4 years ago

ejiektpobehuk commented 4 years ago

I'm planning to play a bit with github actions and it could be helpful for our PR system by introducing automated checks.

The question is what should we check? I've came up with a next list:

no colours other than white (#ffffff or #FFFFFF)
no transparency
no transform
no gradient

I'm interested in suggestions on what to add or delete to/from this list :ear:

dkanada commented 4 years ago

I think we would already have issues with the transform rule because I saw some floating around in the icon folder, but those sound like excellent checks!

douweschulte commented 4 years ago

I always use a minifier with VS Code to remove all unneccesary stuff from my svg files. Which also minifies #ffffff to #fff so please keep that in mind.

dkanada commented 4 years ago

That shouldn't be too important, don't worry.

ejiektpobehuk commented 4 years ago

https://github.com/scour-project/scour looks promising