dkanada / frost

Icon Pack for Android Devices
GNU General Public License v3.0
164 stars 76 forks source link

Some Icons #486

Open frosticons opened 3 years ago

frosticons commented 3 years ago

Hey, I wanted to contribute two icons, one for youtube music vanced and one for the simple dialer app (fdroid). Now, I don't know how git works so I just wanted to ask if someone else could upload them if they are found suitable.

baitmooth commented 3 years ago

Thanks for the icons. If you could also add the activity names like described in https://github.com/dkanada/frost#icon-requests, I will try and include them.

frosticons commented 3 years ago

Dialer \

YT Music \

This is the information I got from Turtl, though I am not sure whether the activity name for the dialer app is of relevance. The dialer app offers different colors for its icon and the activity includes said color ("Purple"). Does that mean only the purple version of the icon will be affected?

Anyways, thanks for trying to include my icons :)

frosticons commented 3 years ago

Here's also an icon for Linguee, though this one I didn't create myself, I pretty much just copied it from https://www.linguee.com/. I don't know whether that's legal, but if it is, this is the icon and the data:

\ \

baitmooth commented 3 years ago

This is the information I got from Turtl, though I am not sure whether the activity name for the dialer app is of relevance. The dialer app offers different colors for its icon and the activity includes said color ("Purple"). Does that mean only the purple version of the icon will be affected?

Thats beyond my understanding how those icons work and I haven't seen it before. If it is relevant @dkanada hopefully knows. I only drop by to draw icons.

baitmooth commented 3 years ago

Here's also an icon for Linguee, though this one I didn't create myself, I pretty much just copied it from https://www.linguee.com/. I don't know whether that's legal, but if it is, this is the icon

I also don't know that. And often my understanding of real legal stuff is quite naive. If you drew some of the lines and don't claim to own linguee it should be fine..

dkanada commented 3 years ago

Since it says purple, you probably need to include the activity names for every single color it supports to make sure they all have the proper icon from this pack.

baitmooth commented 3 years ago

I scaled your icons a little bit. youtubemusic was too big and linguee, and dial slightly too small. I hope thats ok for you, @frosticons . besides that those are all three nice icons. good work.

The other thing is about the dialer app, I took a look at the relevant file and the icon is already present, but only for 'orange'. All other apps in this set have the same feature and have all the colors set to point to the same icon.

In short: If you change to 'orange' you get the frosticon icon right now.

I guess that @dkanada won't accept an unique icon for every color ;)