search

dkanada / gelli

Native Music Player for Jellyfin
GNU General Public License v3.0
527 stars 41 forks source link

Rename Login field: "Server" -> "Server URL" #126

Open QJKX opened 3 years ago

QJKX commented 3 years ago

Thanks for the project.

The login screen has a field for "server". The field actually expects a URL (and didn't work for me without the protocol prefix. This is different to the Android Jellyfin client).

I think it would be clearer if the "Server" field was renamed "Server URL".

poopybunghole commented 3 years ago

Agreed. I kept typing the server IP and a domain name with no result. Eventually I tried http:// and it worked. For the longest time I thought the app was simply broken. Maybe have a selectable toggle for http:// or https:// or have a pre filled out url like http://myjellyfin.server so people know what to do without guessing.

Korvox commented 2 years ago

The prefill sounds like a great UX solution. Maybe just have http:// in there prefilled, people will know what to do with the rest, so when you edit over the placeholder you don't have to type that out. Only concern would be if it does proper upgrading against hsts (preload or response header) for https only sites.

m00nwtchr commented 2 years ago

For a placeholder https would be better, since there's no reason to assume the server doesn't support it in this day and age, and http might make people think the app only supports http