search

dkanada / gelli

Native Music Player for Jellyfin
GNU General Public License v3.0
528 stars 41 forks source link

Server selection entry UI doesn't seem to handle servers at same IP on different ports #163

Open JPLeBreton opened 3 years ago

JPLeBreton commented 3 years ago

I have a jellyfin server running on my home machine, and because that machine is connected to the internet via ethernet on weekends and via wifi on weekdays, it's available at the same IP but different ports (8096 and 8097) depending on day of the week. I would like to use Gelli to connect to it from mobile any of these days, but the current server selection UI makes this impossible.

Steps to reproduce:

  1. Have any kind of setup where two jellyfin servers are at the same IP using different ports
  2. Open Gelli, input info for server #1, and log into it
  3. Later, reopen Gelli when server #1 is down - observe long hang on a grey screen
  4. Eventually, login screen comes up - press Select
  5. Press Add to create a new server
  6. Enter login info for second server and connect
  7. Next time that server goes down, observe long hang on a grey screen again, repeat

I don't know of any other servers I can connect to, so I can't test what is unique about this relative to just any situation where the user is switching between multiple servers with wholly different IPs.

Config: Server: jellyfin 10.7.5-1 on Manjaro Linux Client: Gelli 1.3.0 installed from F-Droid on a OnePlus A6000 running Android 10

dkanada commented 2 years ago

Just to confirm, which of these is your problem in this situation?

  1. The app doesn't automatically attempt to authenticate with the alternate address when the first one fails
  2. You are unable to save both addresses at the same time
JPLeBreton commented 2 years ago

My problem is that I have to re-enter the server address and password every time the server goes from being hosted on one port vs another. If Gelli's UI had a list of saved servers, that would be one way to address it - I'd have two different entries. If it didn't have that but remembered both servers and tried one when the other failed to connect, that would also solve my issue but in a less user-visible way. I'd take either.

dkanada commented 2 years ago

@JPLeBreton the app now includes a list of saved servers, does that resolve your problem?

JPLeBreton commented 2 years ago

Unfortunately, it doesn't. When the server changes ports, I open Gelli and it pauses for a while as it tries to contact the old address - that's okay. Then I'm given the option to enter new server details or Select one of the saved ones. When I tap Select, the sole entry on the list I see is my server at the last port I entered manually, which is the opposite port I want. So I end up having to re-enter my login, password, and server URL every time the server's port changes.

I can't tell what it's doing under the hood, but it's possible that the issue here is that Gelli sees a user entering info for a new server with the same base URL (minus the colon + #### port number) as an already-saved one, and treats it as an edit to one that's already in the saved server list, instead of a new server.

It's also worth noting that my server's full URL (which is only 30 characters) runs off the edge of the text area in the saved server list, meaning I can't read the full URL (ie the important part at the end) unless I turn by device sideways. But that's a separate and less serious problem I can file as its own issue.