dkanada / gelli

Native Music Player for Jellyfin
GNU General Public License v3.0
527 stars 41 forks source link

Login : detect server & users on local network #93

Open ncmtl opened 3 years ago

ncmtl commented 3 years ago

Spent 15 mins trying to understand why I couldn't log on my local server from Gelli. Had to write HTTP://192.168.0.xxx:8096 instead of 192.168.0.xxx Possible solutions to make starting with Gelli easier :

I really like this project, thanks a lot !!

signus commented 3 years ago

Local service (schema+server) detection I think should certainly be in scope for a feature request. However, for HTTPS it would likely need to involve a client-side configuration to allow users to ignore errors/warnings for self-signed certificates. If in the instance that the service can't be detected, port 8096 is a good default to have set.

I don't know that user auditing would be possible to allow the population of users, but I believe that should not be considered for the sake of security - allowing any plausible attacker on a network to gain information they wouldn't otherwise have. That being said - a list of users that have been successfully been authenticated could be cached on the client.

nextlooper42 commented 3 years ago

I took mi like half hour figure out that i need to write http:// ... i was checking everything on server side and wondering why the hell is not working. Why is it there, other Jellyfin app doesn't require this prefix -.-

seniorm0ment commented 3 years ago

Local pin does not work as well I haven't tested with the private IP, but with Jellyfin if you're on the LAN and go to the public domain of your instance, it lets you logon with the pin (which doesn't work on gelli)

reukiodo commented 4 months ago

It should assume sane defaults if not provided.

For example, http if not specified, port 8096 if not specified, as these are Jellyfin's defaults.