search

dkandalov / friday-mario

IntelliJ plugin to have fun 🎮🔊
https://plugins.jetbrains.com/plugin/7599
76 stars 6 forks source link

Support for ideaVim #4

Open abrahamD opened 9 years ago

abrahamD commented 9 years ago

I don't know how the sound bindings are made but when used with the ideaVim plugin no editor sounds are outputted.Only the background music and panel opening.

It might not be fair to ask support for another plugin but perhaps supporting movement and selection regardless of the shortcut would help with cross plugin support.

dkandalov commented 9 years ago

Thank you for reporting this. I'll try adding support for ideaVim this weekend.

Just in case, this plugin was a joke to show what can be done in IDEs. The idea is to play with it for 10 minutes and remove. You don't really miss anything :)

More details:

The sound bindings are implemented as listeners for built-in actions (not shortcuts), e.g. see https://github.com/dkandalov/friday-mario/blob/master/fridaymario/SoundPlayer.java#L121

And it looks like ideaVim implements it's own actions for everything, see https://github.com/JetBrains/ideavim/blob/master/resources/META-INF/plugin.xml#L69

abrahamD commented 9 years ago

Thanks! Honestly, I was really curious to try it out (especially with Vim) but I didn't see it as something critical.

I appreciate your quick response though. If you come across an easy fix I'd definitely go Mario mode the following Friday :D

Edit: Actually, if it's just binding actions to sound can I do a pull request with the custom vim actions?

dkandalov commented 9 years ago

Yes, sure. I think it should be straightforward.

abrahamD commented 9 years ago

Yay! I'll be back with a PR.

dkandalov commented 9 years ago

Hello. Just to let you know I tried it this weekend, but it takes some effort for me to choose sounds because I'm not vim user and don't know shortcuts.

abrahamD commented 9 years ago

Oh, well I didn't really get around to it yet but I guess it would make more sense for me since I am more familiar with the custom actions ^^ .

I'll let you know when I look into it.