dkandalov / limited-wip

IntelliJ plugin to limit your work-in-progress
https://plugins.jetbrains.com/plugin/7655
111 stars 7 forks source link

Relaxed TCR #20

Closed yjaaidi closed 5 years ago

yjaaidi commented 5 years ago

Hi @dkandalov ,

As suggested by Thomas Deniffel here https://medium.com/@tdeniffel/tcr-variants-test-commit-revert-bf6bd84b17d3, it would be nice to only revert production code and not tests.

I think it would be nice to be able to define a whitelist or/and blacklist of files that should be reverted by TCR using wildcards or regex or both.

I guess that wildcard or regex blacklist would be the priority.

Thanks Dmitry!

dkandalov commented 5 years ago

In IJ IDEs test folders are usually (but of course not always) are marked as test in project settings. I think it might be a simpler thing to do for now 🤔

yjaaidi commented 5 years ago

Hi Dmitry,

If it's a quick win, we could start with that but in the JavaScript world for example, it's quiet common to put test files (.spec.ts) next to the tested code.

That's why I thought it would be better to let people choose.

On Tue, Mar 26, 2019, 10:41 AM Dmitry Kandalov notifications@github.com wrote:

In IJ IDEs test folders are usually (but of course not always) are marked as test in project settings. I think it might be a simpler thing to do for now 🤔

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dkandalov/limited-wip/issues/20#issuecomment-476546443, or mute the thread https://github.com/notifications/unsubscribe-auth/ACjP4iSv4I3KfyqMLGmEBvgNLBlfNgvvks5vaetWgaJpZM4b5VJo .

dkandalov commented 5 years ago

Done in plugin version 0.3.3 (it will be available in couple days after jetbrains approves it).

yjaaidi commented 5 years ago

Cool!!! Thank you very much!!!