search

dkangala / hamake

Automatically exported from code.google.com/p/hamake
0 stars 0 forks source link

<exec> should allow zero <parameter>s #47

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
  1. Create an <exec> rule without <parameter> subelements.
  2. Attempt to run it.

What is the expected output? What do you see instead?

  I expect the executable specified in the binary= attribute to be run.  Instead, I get an XML validation error.

Please use labels and text to provide additional information.

  The attached patch simply relaxes the constraints on <exec> to allow zero or more <parameter> subelements rather than requiring one or more.

  The patch also removes <jobconf> as an allowed subelement of <exec>.  It is not meaningful for <exec> and was furthermore allowed only by the XSD schema, not the RNG one.

-peter

Original issue reported on code.google.com by petenewc...@gmail.com on 22 Jul 2011 at 9:56

Attachments:

GoogleCodeExporter commented 9 years ago 
I've applied the patch. Beside that, I've also changed constraints of minimum 
number of parameters for <mapred> and <pig> tasks from 1 to zero.

Sincerely,
Vladimir

Original comment by v...@codeminders.com on 25 Jul 2011 at 5:03

GoogleCodeExporter commented 9 years ago

Original comment by kroko...@gmail.com on 25 Jul 2011 at 10:04