dkangala / hamake

Automatically exported from code.google.com/p/hamake
0 stars 0 forks source link

Empty <foreach> input <fileset> folder causes failure #50

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a hamakefile with a <foreach> element whose input is a <fileset> 
whose path is
   an empty folder.
2. Run hamake on the hamakefile.

What is the expected output? What do you see instead?

  I expect hamake to exit successfully-- there's nothing to update.  Instead, it fails and
  reports the empty input folder as an error.

  Obviously, this is not so much a bug as a feature that interferes with my use case.

Please use labels and text to provide additional information.

  I've attached a patch that turns the error into a warning and counts the execution of
  the <foreach> as successful rather than failed.

-peter

Original issue reported on code.google.com by petenewc...@gmail.com on 3 Aug 2011 at 9:06

Attachments:

GoogleCodeExporter commented 9 years ago
I tend to agree with Peter that this should be a warning. Please review and 
apply.

Original comment by kroko...@gmail.com on 3 Aug 2011 at 11:47

GoogleCodeExporter commented 9 years ago
patch applied, and use case is covered with unit test

Thanks,
Vladimir

Original comment by v...@codeminders.com on 4 Aug 2011 at 12:51

GoogleCodeExporter commented 9 years ago
Thanks!

-peter

Original comment by petenewc...@gmail.com on 4 Aug 2011 at 1:14