search

dkaoster / scrolly-video

Components for scroll-based (or other externally controlled) playback.
https://scrollyvideo.js.org/
MIT License
965 stars 39 forks source link

`videoPercentage` is passed from React component to JS class but ignored #120

Open BThero opened 2 weeks ago

BThero commented 2 weeks ago

Here in the ScrollyVideo.jsx component, we can see videoPercentage being passed into the JS class.

But a quick CMD+F in the ScrollyVideo.js file reveals that the passed value is not used at all. Not sure how this affects things, but might be a cause for some unintended bug.