search

dkaoster / scrolly-video

Components for scroll-based (or other externally controlled) playback.
https://scrollyvideo.js.org/
MIT License
965 stars 39 forks source link

feat: add data-scrolly-container attribute to vue and svelte as well #97

Closed tarsisexistence closed 6 months ago

tarsisexistence commented 6 months ago

I added it to react JSX in the previous PRs, but I think it can also be useful for Vue and Svelte wrappers, since this is the way how outer code can reach the wrapper node.

Though, it's a static approach. It can also be done via classNames but ... let's just keep data attributes until users come with a request for classNames.