search

dkaschek / dMod

Dynamic modeling and parameter estimation in R
19 stars 8 forks source link

vcov defined in dMod and stats #53

Open marcusrosenblatt opened 4 years ago

marcusrosenblatt commented 4 years ago

Hi,

I do not know when this was implemented, but dMod provides a function vcov that overwrites the standard stats::vcov. Can lead to problems for "good old blotIt" (not blotIt2) functions. Thought this could be of general interest. If your code is outrunning the time your project takes.... ;-)

Is it possible to rename the dMod::vcov or make use of a different class?

Best, Marcus

marcusrosenblatt commented 4 years ago

Maybe easier: I could change the vcov in blotIt to stats::vcov.

dkaschek commented 4 years ago

Please implement in dMod that trust() and trustL1() return class c("trust", "list"). Then rename vcov to vcov.trust such that it is exported as an M3 method. Please test if everything works as expected.

On Thu, Mar 12, 2020 at 11:11 AM Marcus Rosenblatt notifications@github.com wrote:

Maybe easier: I could change the vcov in blotIt to stats::vcov.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dkaschek/dMod/issues/53#issuecomment-598106755, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADQ55VPTKQROQGXBXIEUONLRHCYL3ANCNFSM4LGIXM4A .

--

IntiQuan GmbH Spalenring 150 4055 Basel, Switzerland Web: www.intiquan.com Tel: +41 76 603 28 06

Confidentiality Note: This message is intended solely for the designated recipient(s). It may contain confidential or proprietary information and may be subject to attorney-client privilege or other confidentiality protections. If you are not a designated recipient you may not review, copy or distribute this message. If you receive this in error, please notify the sender by reply e-mail and delete this message. Thank you.

Data Protection & Privacy: The IntiQuan Data Protection statement applies for all communication. You can view it here: https://www.intiquan.com/data-protection.

IntiQuan GmbH | Managing Director: Dr. Henning Schmidt | Trade register: Basel Stadt CH-270.4.004.907-8 | UID: CHE-181.306.90

dlill commented 4 years ago

Maybe easier: I could change the vcov in blotIt to stats::vcov.

Nevertheless, that kind of thing is always a good idea