search

dkavolis / Ferram-Aerospace-Research

Aerodynamics model for Kerbal Space Program
Other
80 stars 32 forks source link

Add ReStock bug hotfix #28

Closed Zuthal closed 5 years ago

Zuthal commented 5 years ago

Due to way in which some engines' meshes are created in the ReStock and ReStockPlus mod, FAR treats these engines as being much larger, for aerodynamics calculations, than they really are.

This MM config file forces FAR to use colliders on these engines.

dkavolis commented 5 years ago

Thanks for the PR but these should be distributed with ReStock instead. In addition, the patches should probably require ReStock as dependency since stock parts are unaffected and should be left using mesh voxelization instead.

Zuthal commented 5 years ago

Oh, true, they probably should.

I assume I do that simply by editing the individual configs to be

@PART[rapierEngine]:AFTER[FerramAerospaceResearch]:NEEDS[ReStock]
{
    @MODULE[GeometryPartModule]
    {
        %forceUseColliders = True
    }
}

with the respective part name (and ReStock replaced with ReStockPlus for the ReStockPlus engines)?

dkavolis commented 5 years ago

I'm not very good with MM patches, if you post on ReStock repo they should help you out better

Zuthal commented 5 years ago

They seem to work, at least the fixes apply correctly with ReStock present. Will submit a PR on the ReStock repo, then.

dkavolis commented 5 years ago

Fixed in #30