search

dkavolis / Ferram-Aerospace-Research

Aerodynamics model for Kerbal Space Program
Other
80 stars 32 forks source link

1.6.1 Install Toolbar Icon Missing #46

Open pap1723 opened 5 years ago

pap1723 commented 5 years ago

Created a 1.6.1 install for testing purposes and the Toolbar icon for FAR is not found and there is just a black box instead.

dkavolis commented 5 years ago

It's there on my version of KSP, do you have a log?

KZdavid commented 4 years ago

Me, with 1.7.3 also have the problem. With only RO, RSS and their minimmum dependencies.

dkavolis commented 4 years ago

This seems to be an issue with KSP loading textures, I have added a workaround in dev branch for KSP 1.8+ but I'm not interested in backporting.

KZdavid commented 4 years ago

When the fix for 1.8+ is done, could you please expain it here if it's simple? I'm willing to do that backporting for KSP 1.7.3 if it's not too hard for me.

dkavolis commented 4 years ago

In your case, I would suggest only backporting the relevant bits since I've used new .NET and Unity API from 1.8 in quite a few places.

The relevant code is: https://github.com/dkavolis/Ferram-Aerospace-Research/blob/ddd7e92fbd1f417101bbeb64e62d1640ed134321/FerramAerospaceResearch/FARAssets.cs#L170-L188

which in dev branch can be configured to instead load using Unity API https://github.com/dkavolis/Ferram-Aerospace-Research/blob/c74e78ec2f321277d180801613d3e184df249d50/FerramAerospaceResearch.Base/Resources/Loading/TextureLoader.cs#L8-L47

Looks like the Unity API has not changed https://docs.unity3d.com/2017.3/Documentation/ScriptReference/Networking.DownloadHandlerTexture.html https://docs.unity3d.com/2017.3/Documentation/ScriptReference/Networking.UnityWebRequestTexture.html

so I might just do it myself.

dkavolis commented 4 years ago

Try https://github.com/dkavolis/Ferram-Aerospace-Research/tree/1.7_update

KZdavid commented 4 years ago

It seems that select the ‘High' texture in KSP setting will fix the problem.