Log spam and very low fps in VAB/SPH when RF UI is open

dkavolis / Ferram-Aerospace-Research

Aerodynamics model for Kerbal Space Program

Other

80 stars 32 forks source link

Log spam and very low fps in VAB/SPH when RF UI is open #67

Closed Gordon-Dry closed 5 years ago

Gordon-Dry commented 5 years ago

When the tank UI of MFT/RF is open in VAB/SPH, this is spammed to the log and the reaction times are disgustingly low:

[FAR v0.15.10.1] Updating CRAFTNAME *

(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/DebugBindings.gen.cpp Line: 51)

obvious, I edited that, enter name of actual craft there

dkavolis commented 5 years ago

Can you give the full log?

Gordon-Dry commented 5 years ago

https://www.dropbox.com/s/w24adhkpn289sp0/output_log.txt%20and%20stuff%202019-06-07-01.zip?dl=1

dkavolis commented 5 years ago

Can't reproduce it on my setup. RF UI lags a lot though but it's not due to FAR.

Gordon-Dry commented 5 years ago

Ok. It's just that the FAR log spamming only occurs when the RF UI is open.

dkavolis commented 5 years ago

Something is probably firing editor events, which FAR subscribes to:

GameEvents.onEditorVariantApplied
GameEvents.onEditorPartEvent
GameEvents.onEditorUndo
GameEvents.onEditorRedo
GameEvents.onEditorShipModified
GameEvents.onEditorLoad

Gordon-Dry commented 5 years ago

This (yes for real) exiting issue seems to be fixed with https://github.com/NathanKell/ModularFuelSystem/pull/222

Fix needs testing.