search

dkavolis / Ferram-Aerospace-Research

Aerodynamics model for Kerbal Space Program
Other
80 stars 32 forks source link

Compatability to KSP1.8 #80

Closed lukecologne closed 4 years ago

lukecologne commented 4 years ago

Quickly tested, GUI works, and it produces sensible values. Unfortunately I currently don't really have time for more extensive testing. Debug voxels don't work, probably need to update shaders.

dkavolis commented 4 years ago

Thanks for the PR, saved me some time setting up new Unity dependencies. I've updated shaders and version so if there are no problems this would be the release version. It seems that everything works fine in 1.8 but I would like to test some more. Binaries are included in the last commit.

lukecologne commented 4 years ago

Yes, that is probably best. I can take a quick look and search for any bugs, but I don't really have time for in-debth testing atm. unfortunately.

lukecologne commented 4 years ago

So, after a bit of testing, I didn't encounter any bugs at all. Debug voxels work perfectly, sensible values when flying. I did not encounter NRE's when placing control surfaces, or loading crafts that were saved with FARControllableSurface, but I did get an NRE when loading stock crafts. They were the same as described here, so not created by FAR.

dkavolis commented 4 years ago

Thanks, it looks like the only issue is Scale_Redist, there are issues with loading it

ADDON BINDER: Cannot resolve assembly: Scale_Redist, Culture=neutral, PublicKeyToken=null
    UnityEngine.Debug:LogErrorFormat(String, Object[])
    AssemblyLoader:MyResolveEventHandler(Object, ResolveEventArgs)
    System.Reflection.Assembly:Load(AssemblyName)
    AssemblyLoader:MyResolveEventHandler(Object, ResolveEventArgs)
    System.Reflection.Assembly:GetTypes()
    AssemblyLoader:LoadAssemblies()
    <LoadObjects>d__89:MoveNext()
    UnityEngine.MonoBehaviour:StartCoroutine(IEnumerator)
    <CreateDatabase>d__70:MoveNext()
    UnityEngine.MonoBehaviour:StartCoroutine(IEnumerator)
    GameDatabase:StartLoad()
    <LoadSystems>d__11:MoveNext()
    UnityEngine.MonoBehaviour:StartCoroutine(IEnumerator)
    LoadingScreen:Start()

Tried recompiling with .NET 4.x and replacing Scale_Redist from currently maintained fork but I get the same errors everytime.

dkavolis commented 4 years ago

Ok, Scale_Redist is actually loaded so these AssemblyLoader errors are harmless.