dkazanc / TomoPhantom

Software to generate 2D/3D/4D analytical phantoms and their Radon transforms (parallel beam) for image processing
https://dkazanc.github.io/TomoPhantom/
Apache License 2.0
116 stars 53 forks source link

FISTA iterative reconstruction method #49

Closed dkazanc closed 5 years ago

dkazanc commented 6 years ago

Implement FISTA as a part of TomoPhantom.

paskino commented 6 years ago

I guess that's a bit of a political question, but why would you do it and not use the cil implementation?

As far as I can tell it would work fine on numpy arrays provided that you passed appropriate functions

dkazanc commented 6 years ago

Classical FISTA it's just a few lines, so it almost done. Why not CIL, a number of reasons.

Having said that, I still think having CIL as a plugin in Savu would be a good thing, especially to access other algorithms that require more effort than FISTA.

dkazanc commented 6 years ago

I even think that using FISTA from TomoPhantom is a bit too much due to additional dependence. I'd view Savu as a collection of independent self-contained plugins, which developers/users can modify if need to. If the method/algorithm is not directly exposed in Savu it is difficult to maintain it.