search

dkazanc / TomoPhantom

Software to generate 2D/3D/4D analytical phantoms and their Radon transforms (parallel beam) for image processing
https://dkazanc.github.io/TomoPhantom/
Apache License 2.0
116 stars 53 forks source link

Flat-field simulator #68

Closed dkazanc closed 5 years ago

dkazanc commented 5 years ago

@paskino There is a problem. Somehow I cannot from tomophantom.supp.flatsgen import flats or from tomophantom.supp.normraw import normaliser_sim which are both in the folder. Please check, DemoReconASTRA3D_sim.py demo must work. Thanks!

dkazanc commented 5 years ago

OK. this looks like a bug. condabuild generates tomophantom-0.10.3-py35 version which it doesn't install. Instead it installs older 1.2.0-py35 which doesn't contain changes above. I installed tomophantom-0.10.3 and I've got new files.

dkazanc commented 5 years ago

removing --force helps to install the correct version, so conda install tomophantom --use-local. Conda also tells that --force will become obsolete?

dkazanc commented 5 years ago

actually the above didn't help either.

paskino commented 5 years ago

OK. this looks like a bug. condabuild generates tomophantom-0.10.3-py35 version which it doesn't install. Instead it installs older 1.2.0-py35 which doesn't contain changes above. I installed tomophantom-0.10.3 and I've got new files.

Jenkins sets the version as the last tag_<number of commits from tag>. So 1.2.0 seems to be from Jenkins, unless it's another manually set version.

Actually I've just checked and the last tag is v1.2 so Jenkins will make a 1.2 version not a 1.2.0. The 0.10.3 seems to be manually set.

At any rate conda thinks that 1.2.0 > 0.10.3 and installs the largest versions by default unless you instruct it to do install a specific version.

conda won't downgrade unless forced.

So it's not a bug. It is expected.

Regarding --use-local this is going to disappear and you should use the standard -c <path to conda-build directory> channel definition.