Closed NamelessCoder closed 7 years ago
Breaking change: API of Client
class is different when using custom HTTP invoker as illustrated in examples
I apologise for the combined commit which Ideally should have been several smaller commits. The only excuse I have is the dependency puzzle was a lot harder to solve without removing those dependencies - and detecting usages of classes was very difficult due to the classname-in-string occurrences.
Caveats:
->json
on Response
is now mimicked with several json_decode
calls and casts to array. This only mimics the behavior and doesn't throw JSON-specific exceptions. Instead, data integrity exceptions will be thrown. No test cases cover this.Suggested next steps:
league/url
to league/uri
- I had initially attempted to include this switch as well, but opted to avoid it to keep the change smaller (it's big enough already...)
This patch:
::class
for easier tracking while upgrading