Closed dkerr64 closed 7 months ago
fixed in 1.5.4
I've been having issues with the status of the Garage door and seeing these messages in the log after using the app to open/close: [YoLink] [YS4906-UC (...) Garage Door Controller] YoLinkAPI.setDeviceState: undefined
Hoping this fix will address that too
@jimcrammond That is unrelated to this problem, the undefined is actually expected in this case...
Explanation: YoLink's garage door solution is somewhat primitive. Two devices are involved, one that senses whether the door is open or closed, another that triggers the door to open or close. But the open/close is a toggle, you don't ask it to open or close, you ask it to toggle, whether it opens or closes depends on its current state.
This complicates things enormously, as this plugin has to try and determine what the current state is... because you don't want to toggle the door state when HomeKit asks it to close, if it is already closed. But if the door is in motion then the plugins view of whether it is open or closed may be wrong.
What has all this to do with the log message... because you can't ask the door controller to explicitly open or close, there is no command string sent to the device, it is deliberately empty (undefined).
Now that you bring this up I realize that undefined may be alarming to a user. So I have changed the log message to state that it is toggling. As this is a non-functional change I won't publish a new release just for this but it will be included whenever I need to publish again.
Thanks for bringing this up.
Okay. I may have a separate issue then. Let me isolate my issue a bit more and post a separate issue if it still happens