search

dkfans / keeperfx

Open source remake and Fan Expansion of Dungeon Keeper.
https://keeperfx.net/
GNU General Public License v2.0
777 stars 77 forks source link

Additional settings will break compatibility with old ones #1090

Open Loobinex opened 3 years ago

Loobinex commented 3 years ago

What will happen is that all settings get scrambled (or shifted down the list).

Desired behavior would be for the game to recognize the settings format has changed, and either: A) Pick up the default setting for the new one and keep the other settings B) Delete settings.dat restoring all settings to default.

Steps to reproduce: 1) Have default or custom settings from the master branch 2) Build the code from PR #1088 3) Install that version, start a level 4) Press for example P to Pause or Esc for menu and notice something else will happen.

walt253 commented 1 month ago

Related issue: https://github.com/dkfans/keeperfx/issues/3329

SimLV commented 1 month ago

We have to put settings into toml file instead of settings.dat with some sane names. So 

[shortcuts]
navigate_heart = "h"

will be future proof until we rename some of these actions