dkfans / keeperfx

Open source remake and Fan Expansion of Dungeon Keeper.
https://keeperfx.net/
GNU General Public License v2.0
762 stars 76 forks source link

Blood particles do not splatter on walls #2531

Open Spatulade opened 1 year ago

Spatulade commented 1 year ago

This was an issue I mentioned a long time ago (but never raised as an issue) where blood particles do not splatter when they come in contact with walls:

ezgif-2-3e50252d10

I still have a recording I made from a much older version of the game for a better reference of how they should behave (not perfect but much better), but sadly I don't remember what alpha this was from:

https://github.com/dkfans/keeperfx/assets/100633508/0c78f381-1e67-49a4-9c6f-0526812b49e9

yani commented 1 year ago

It's the "blood puddle" that's floating in the air on the wall, right? On the top it's just the droplets that hang on the wall?

if I'm correct, the top one looks more natural. A floating puddle isn't really good. Maybe it's possible that if this gets changed back to "floating puddles", they can be rotated 90 degrees? Otherwise I'd kind of prefer the droplets over puddles

Loobinex commented 1 year ago

We cannot rotate sprites. That's like trying to see a bile demons butt hole. We all know it is there, but we can never see it.

Spatulade commented 1 year ago

I feel like it splattering on the walls looks less wrong, especially because they disappear much quicker. When they just float on the walls it looks wrong. Theoretically someone could make a quick animation of it dripping down the walls, but that's probably a bit much

Loobinex commented 1 year ago

what if all the droplets point down?

Spatulade commented 1 year ago

Go for it, and if it looks weird they can point up again

yani commented 1 year ago

We cannot rotate sprites. That's like trying to see a bile demons butt hole. We all know it is there, but we can never see it.

You misunderstood me. Imagine the puddles "pointing sideways"

Loobinex commented 1 year ago

photoshop me

yani commented 1 year ago

photoshop me

Well, I'll photoshop you later, but for now I'll photoshop what I mean:

image

The animated sprites shown on the ground, rotated 90 degrees and put on the wall on the right side.

I'm not sure if there's a front perspective, which would be the same as looking from top to bottom for the ones on the ground.

Spatulade commented 1 year ago

Don't you also need left side as well? Sounds very complicated to get all the different views

yani commented 1 year ago

Don't you also need left side as well? Sounds very complicated to get all the different views

Changing the sprites when they hit those sides is the hard part, rotating them isn't.

Also, I don't fully understand what is actually different in your examples.

Spatulade commented 1 year ago

If you can rotate them so they always look good, sure!

In the pictures, the top one is the current versions, where blood drops splatter on the floor but stay floating when they contact the walls, which is wrong. The lower picture is from older version where the drops (mostly) splatter on walls as they should (but not 100%)

yani commented 1 year ago

Do you have some other examples? I think this also just could be a randomness factor.

Spatulade commented 1 year ago

I don't think it's randomness. I believe it started when collision code was changed. For examples, compare a creature doing the same thing in the og version or from a few years ago

yani commented 1 year ago

I think the original game actually has a bug, where the puddles are created inside of the wall. It might be that they have a trajectory inside of the wall, where they use horizontal collision to become a puddle on top of a cube, instead of using vertical collision to become a puddle with the wall itself.