dkfans / keeperfx

Open source remake and Fan Expansion of Dungeon Keeper.
https://keeperfx.net/
GNU General Public License v2.0
773 stars 76 forks source link

Incorrect creature combat behavior #3275

Open Loobinex opened 5 months ago

Loobinex commented 5 months ago

There is a new bug where units behave weirdly in combat. Attached are 2 packet files that reproduce 2 different situations:

1) The top left salamander will behave like a ranged unit and only back out of combat. image

2) Out of the 8 goblins that should attack the 2 black knights, a bunch refuse to fight and will stand still inside the knight.

To reproduce:

I have traced the bug down to be introduced in Alpha 3935. Revert the commit from 2024-04-26, 19:22 and run the packets again to see both the salamander and the goblins behave correctly.

AdamPlenty commented 5 months ago

I get broken Hell Hounds when I run the packets.

Warning: The global creature model config file "./creatrs/goblin.cfg" doesn't exist or is too small. Warning: The global creature model config file "./creatrs/salamander.cfg" doesn't exist or is too small. Warning: The global creature model config file "./creatrs/maiden.cfg" doesn't exist or is too small. Warning: The global creature model config file "./creatrs/black_knight.cfg" doesn't exist or is too small.

Was the zip supposed to include these configs too?

Loobinex commented 5 months ago

Was the zip supposed to include these configs too?

Yes. I updated the file in the first post to include them now too.

BovenDien commented 2 months ago

I've loaded this up on alpha (4084) and combat is working as it should, above bugs were not present.

Loobinex commented 1 month ago

I've loaded this up on alpha (4084) and combat is working as it should, above bugs were not present.

I can reproduce it still, but can also reproduce it in the 1.1.0.3944 build (the full release).

walt253 commented 1 month ago

Maybe it has something to do with max melee/ranged opponents?