Closed davidpelayo closed 5 years ago
HI @davidpelayo,
This issue is quite likely due to the changed regular expression match that we use to identify placeholders in translation strings. With the new regex matcher, we require at least two characters, which breaks your code if the variable replacement results in a matcher with only one character (i.e. a number).
I will adapt the regex matcher to also include matches for single characters as long as they match [A-Za-z0-9_]. Stay tuned.
should be fixed in latest release v1.10.9
Additionally, to my message above, the latest version fails on IE11 due short hand properties not being transpiled, such us this.
Where:
SET_LOCALE(state, payload) {
}
It should be:
SET_LOCALE: function(state, payload) {
}
Is this intended?
Hi @davidpelayo
Thank you for reporting this. Definitely not intended. I will look into this.
Hi there,
The issue should be fixed now in version v1.10.10. I needed to change the build process somewhat, as babel needs the node_modules and babelrc file to be in the same root directory as the scripts to transpile.
I'm checking the differences of the
v1.10.5
andv1.10.7
due I had translations using multiple placeholders that they were getting translated correctly before, and after upgrading they fail.The comparison link, between those two versions, is the following: https://github.com/dkfbasel/vuex-i18n/compare/v1.10.5...v1.10.7.
So, were before this was correctly working:
With the version
v1.10.7
returns the followingNot all placeholders found
.And I'm starting to suspect the root cause of this issue is at this line of code. Which actually relates to #98 and #99.
Please, any feedback or fix, is welcome.