Add some basic testing - Githubissues

dkhd / winterly-tab

Beautifully replace the new-tab page in your web browser with winter-themed background. It's free & open source!

https://tab.winterly.app

MIT License

10 stars 7 forks source link

Add some basic testing #27

Closed berviantoleo closed 3 years ago

berviantoleo commented 3 years ago

Motivation

Initiate with unit/end-to-end testing.

Changes

Add basic testing, as an example we can render properly
Make sure some important outputs are correct and as expected
Add coverage runner, this is an example output (but this coverage is not an indicator of our code being full tested)

coverage

Related

Relate with discussion: https://github.com/dkhd/winterly-tab/discussions/26

Additional Comments

I just initiate the testing. Maybe we can improve more so the testing can cover many things.
I add PropTypes too, this is will help us to check the proper props that we need in the component. If you do not agree, feel free to tell me, I will remove it.
If have other suggestions, feel free to ask me.

netlify[bot] commented 3 years ago

✔️ Deploy Preview for tab-winterly ready!

🔨 Explore the source changes: 4620a5d05159a4367a8580c76194264448d4072f

🔍 Inspect the deploy log: https://app.netlify.com/sites/tab-winterly/deploys/6166db1cc0b90b000885f1de

😎 Browse the preview: https://deploy-preview-27--tab-winterly.netlify.app/

dkhd commented 3 years ago

Thank you @berviantoleo 😊 this is awesome

@all-contributors please add @berviantoleo for code and test

allcontributors[bot] commented 3 years ago

@dkhd

I've put up a pull request to add @berviantoleo! :tada: