search

dkilgore90 / google-sdm-api

Apache License 2.0
70 stars 22 forks source link

Fixed time format issues, added heat/cool deadband #42

Closed wir3z closed 4 years ago

wir3z commented 4 years ago

It seems that 1 out of 5 of my Google devices reports JSON timestamps in nano-second precision. The changes to the app force that to be formatted back to millisecond to eliminate the toDatetime() exceptions. Works for both nano and milli timestamps.

If you are in heat/cool mode, Nest needs there to be a minimum 1.5C dead band between those two setpoints. If you manually adjust the temperatures, it will automatically bump up/down the other setpoint to keep this rule valid. The changes in the thermostat driver do the same for heat and cool mode. In heat/cool, it just traps the error since there is no way to determine which setpoint "wins".

dkilgore90 commented 4 years ago

Nice work! Merging to develop. Will add *F compatibility on the deadband checks before releasing on master

wir3z commented 4 years ago

Good catch with the *F. I have no clue why Google is sending such precision with just one of those devices, but it explains why I kept saying I was getting exceptions from the app.

Lyle

From: dkilgore90 notifications@github.com Sent: October 31, 2020 10:46 AM To: dkilgore90/google-sdm-api Cc: Lyle Pakula; Author Subject: Re: [dkilgore90/google-sdm-api] Fixed time format issues, added heat/cool deadband (#42)

Nice work! Merging to develop. Will add *F compatibility on the deadband checks before releasing on master

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/dkilgore90/google-sdm-api/pull/42#issuecomment-719958562, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOK3OSUZJIV6XVPQQAWD4OLSNQ5N7ANCNFSM4TF56ALA.

dkilgore90 commented 4 years ago

I'm curious -- what type of device (camera, doorbell, display) was giving you the microsecond precision? I don't have any displays, so wondering if that is the abnormality?

wir3z commented 4 years ago

It is a Nest 3rd Gen Learning thermostat. The "odd" thing is I have an identical unit for my upstairs which was purchased at the same time which does not do this. Of course all my fiddling with the app was with this unit, so it never clicked in why only it was tossing the error.

From: dkilgore90 notifications@github.com Sent: October 31, 2020 11:05 AM To: dkilgore90/google-sdm-api Cc: Lyle Pakula; Author Subject: Re: [dkilgore90/google-sdm-api] Fixed time format issues, added heat/cool deadband (#42)

I'm curious -- what type of device (camera, doorbell, display) was giving you the microsecond precision? I don't have any displays, so wondering if that is the abnormality?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/dkilgore90/google-sdm-api/pull/42#issuecomment-719960867, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOK3OSRJIUUZKTW6Y237OGLSNQ7VVANCNFSM4TF56ALA.