dkim0419 / SoundRecorder

A simple sound recording app implementing Material Design
GNU General Public License v3.0
1.49k stars 807 forks source link

Merge pull with updates from API level 21 to API level 28 #117

Open MarcoTTC opened 5 years ago

MarcoTTC commented 5 years ago

Hi. You may not know me, but my name is Marco, and I'm trying to make a break in my career as a mobile software developer. Thus, I've decided to contribute to some open source GitHub mobile projects I've seen around. I've chosen SoundRecorder as my first try, and I've updated the project to build and deploy as a target API level 28 android project, modifying the code whenever needed to make it so. I've tried to make my commits small and didactic as possible. Since I put some effort into making sure the code compiles, I hope you can appreciate my changes to the code, and accept the merge pull request, but if you could also launch a new version on Google Play, that would be great. Also, I hope to add this project to my portfolio as something I've contributed code towards to, respecting the original authorship. Thank you for your time, and I hope you like my efforts with SoundRecorder.

MarcoTTC commented 5 years ago

Thanks for mentioning the special audio permission and notification for Android Pie. I'll make sure to double check the proper audio requisition and usage in Pie. Also, I may be mistaken, but I think only external data write permission and microphone recording are considered dangerous by Android standards, while audio playback and external data reading are not, but I'll double check it too and implement the proper changes when I have the time. Thank you again.