dkim0419 / SoundRecorder

A simple sound recording app implementing Material Design
GNU General Public License v3.0
1.49k stars 808 forks source link

master #123

Closed shresthajibesh closed 3 years ago

naXa777 commented 5 years ago
  1. You request permissions at runtime in RecordFragment, but don't do this in PlaybackFragment. Let's assume that permissions for recording (MIC + STORAGE) were granted and then revoked. In this case, when a user goes to the Recordings tab and plays a recording, what will happen? Does the app handle this case properly?
  2. Android Pie requires special permission and a persistent notification for sound recording in the background. Please verify this use case as well.

Please test the mentioned use cases and apply changes if required.

PS. The pull request title "master" is not descriptive. could you come up with a better title?