search

dkim0419 / SoundRecorder

A simple sound recording app implementing Material Design
GNU General Public License v3.0
1.49k stars 807 forks source link

Store recording metadata on the filesystem #59

Open gaul opened 7 years ago

gaul commented 7 years ago

This removes use of the database and allows media management via USB MTP. Originally written by @stsydow and sourced from https://github.com/stsydow/SoundRecorder/commit/2b4c02e3d21964063df2bbc96a31ebfc971186ac . Modified by @andrewgaul to remove extraneous changes and rebase onto master. Fixes #47.

gaul commented 7 years ago

@fabianrost84 @stsydow Please review.

stsydow commented 7 years ago

Looks good to me but haven't tested or build it yet.

fbnrst commented 7 years ago

https://github.com/andrewgaul/SoundRecorder/blob/4d761b6aa22b76bf6d59465d63d2dc65ede74823/app/src/main/java/com/danielkim/soundrecorder/RecordingService.java#L114 causes problems when I try to build. Should make use of a timestamp instead, right?

gaul commented 7 years ago

@fabianrost84 Sorry I did not test this after reverting the timestamp commit. The latest commit should fix this.

dkim0419 commented 7 years ago

does this check for cases where there are other files in the parent folder, that aren't mp4's, for example a random jpg? or cases where file formats could be different (ie: some are saved as mp3, some as mp4, etc), could it cause an issue in the future when retrieving metadata?

gaul commented 7 years ago

The only check is to ensure SoundRecorder does not overwrite an existing recording. It parses the recording number to generate the next recording in the sequence, e.g., My Recording_4.mp4. If we support multiple formats we could remove the suffix part of the test.

If we bring back timestamp filenames from #43 we can remove this logic.