Closed ashandonay closed 3 weeks ago
This is looking good! Here are some notes on the first section (1D space, 1 source):
ngrid
in many cells, but never used this value later. I would just put the constants directly into the Grid(...) constructors.b
and m
as constants in the parameter Grid, so they could be allowed to vary, instead of treating them like hyperparams like sigma_s
.s
grid should be expanded to avoid truncation at the edges.Referring to the latest changes, L=10
is useful to define once since you use it in several cells (unlike ngrid
).
I added the location finding problem notebook in the examples folder. The notebook includes the 1D space and 2D space problems with one and two sources in each case.