dkirkby / bossdata

Tools for accessing SDSS BOSS data
MIT License
1 stars 3 forks source link

readthedocs failing #108

Closed dkirkby closed 6 years ago

dkirkby commented 8 years ago

Recent builds are failing with:

% python /home/docs/checkouts/readthedocs.org/user_builds/bossdata/envs/latest/bin/pip install \
--exists-action=w -rrequirements.txt
...
Collecting fitsio==0.9.7 (from -r requirements.txt (line 6))
  Downloading fitsio-0.9.7.tar.gz (6.0MB)
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 20, in <module>
      File "/tmp/pip-build-kyYwC0/fitsio/setup.py", line 4, in <module>
        import numpy
    ImportError: No module named numpy

The solution is probably to add numpy (and scipy?) to requirements.txt, but I'm not sure what changed to make this necessary if it wasn't before.

dkirkby commented 6 years ago

The problem is that running python setup.py egg_info fails after pip-installing fitsio, because it imports numpy (see esheldon/fitsio#143).

Why is readthedocs installing all of my requirements.txt in the first place (e.g., here)?

dkirkby commented 6 years ago

Remove the requirements.txt since it seems to do more harm that good:

dkirkby commented 6 years ago

That still doesn't work since running python setup.py install still indirectly installs fitsio.

dkirkby commented 6 years ago

Solution is to update setup.py in my own fork of fitsio and then have rtd install it via:

git+https://github.com/dkirkby/fitsio

in a new docs/rtd-pip-requirements (which I point to in the RTD Adv Settings)