search

dkirkby / bossdata

Tools for accessing SDSS BOSS data
MIT License
1 stars 3 forks source link

implement --globus option in bossfetch to prepare globus transfer file #30

Closed dmargala closed 9 years ago

dmargala commented 9 years ago

Addresses #16

dkirkby commented 9 years ago

@dmargala Please add some text to bin/scripts.rst mentioning this new option and when it should be used.

dkirkby commented 9 years ago

We want to have consistent behavior for --save with and w/o --globus. It looks like we currently keep going with the transfer for --save but not for --globus --save. There is also a --dry-run option that stops the program after building the file list but before doing any transfers. There are different ways to be consistent: what do you recommend?

dmargala commented 9 years ago

I think the simplest thing to do for now is to add return 0 at the end of the if args.save: block.

I'm not sure what the use case is for a non-globus --save. I have the general impression that a --dry-run shows what files would be transferred. I think they're fine as is and are helpful for testing new file types to fetch.

dkirkby commented 9 years ago

The use case is turning a target list into a file manifest, e.g. for a regression test, for interfacing with rsync, to compare between pipeline versions, or to feed a future --load option.

I agree with adding return 0 to the non-globus --save case (and just leave --dry-run as it is for now).