Closed dkirkby closed 8 years ago
Similarly, sometimes loglam
is useful (instead of wavelength
) for compatibility with already written software.
Yes, good point. That should clearly be an either/or option. Can you think of a use case for returning both ivar and dflux?
One case where both are used, though getting ivar would be sufficient: averaging together fluxes (ivar as weights) and also outputting the combined sigma/dflux.
I am working on the averaging use case right now to try and figure this out...
Closed with PR #88
The
get_valid_data
methods fromSpecFile
,PlateFile
andFrameFile
all returndflux
calculated from internal ivar values. This is often what you want, but sometimesivar
is more useful, e.g., when averaging spectra. I propose to keepdflux
as the default, but add an option to getivar
instead of (or in addition to?)dflux
.