Kompatibilität für Contao 4

[mlwebworker]

Habe heute Deine Erweiterung unter Contao 4.4 (PHP 7.2) manuell installiert. Das hat erst mal soweit geklappt. Leider happert es bei den Bildeinstellungen. Unter Bildbreite und Bildhöhe läßt sich nichts eintragen bzw. auswählen und damit auch nichts abspeichern. Auch das Feld Großansicht/neues Fenster lässt sich nicht anwählen. Alle anderen Einstellungen scheinen ok. Ich würde da gern weiter testen, aber als Nichtentwickler komme ich hier erst einmal nicht weiter.

Planst Du die Erweiterung auch für Contao 4 freizugeben/weiterzuentwickeln?

[fritzmg]

See #5.

[mlwebworker]

Danke Fritz. Habe es heute gleich mal getestet. Soweit ich das beurteilen kann läuft alles fehlerfrei. Wie läuft das jetzt mit der Freigabe. Ist ja für ein Live-System doch schöner, wenn man die Erweiterung nicht manuell installieren muss.

[fritzmg]

Das hängt von @dklemmt ab :)

[mlwebworker]

Kann man den irgendwie "motivieren"?

[fritzmg]

@mlwebworker vielleicht eine Email schicken? ;)

[mlwebworker]

Erledigt. Muss ich mir mal merken, dass ich im Code die E-Mailadresse finden kann.

[dklemmt]

@fritzmg vielen Dank für deine Arbeit. Wenn @mlwebworker getestet hat und alles fein ist, merge ich den Code gleich rein

[mlwebworker]

Danke

[fritzmg]

Neuer Release Tag sollte auch gemacht werden. (1.2.2)

[mlwebworker]

Die Installation über den Manager und die Konsole funktionieren noch nicht.

Konsolenausgabe:

Problem 1
    - dklemmt/contao_dk_masonry 1.2.0 requires contao/core >=3.0.5,<3.2 -> satis                      fiable by contao/core[3.0.5, 3.0.6, 3.1.0, 3.1.1, 3.1.2, 3.1.3, 3.1.4, 3.1.5].
    - dklemmt/contao_dk_masonry 1.2.1 requires contao/core ~3.2 -> satisfiable b                      y contao/core[3.2.0, 3.2.1, 3.2.10, 3.2.11, 3.2.12, 3.2.13, 3.2.14, 3.2.15, 3.2.                      16, 3.2.17, 3.2.18, 3.2.19, 3.2.2, 3.2.20, 3.2.21, 3.2.3, 3.2.4, 3.2.5, 3.2.6, 3                      .2.7, 3.2.8, 3.2.9, 3.3.0, 3.3.1, 3.3.2, 3.3.3, 3.3.4, 3.3.5, 3.3.6, 3.3.7, 3.4.                      0, 3.4.1, 3.4.2, 3.4.3, 3.4.4, 3.4.5, 3.5.0, 3.5.1, 3.5.10, 3.5.11, 3.5.12, 3.5.                      13, 3.5.14, 3.5.15, 3.5.16, 3.5.17, 3.5.18, 3.5.19, 3.5.2, 3.5.20, 3.5.21, 3.5.2                      2, 3.5.23, 3.5.24, 3.5.25, 3.5.26, 3.5.27, 3.5.28, 3.5.29, 3.5.3, 3.5.30, 3.5.31                      , 3.5.32, 3.5.33, 3.5.4, 3.5.5, 3.5.6, 3.5.7, 3.5.8, 3.5.9].
    - contao/core 3.0.5 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.0.6 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.1.0 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.1.1 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.1.2 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.1.3 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.1.4 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.1.5 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.2.0 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.2.1 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.2.10 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.2.11 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.2.12 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.2.13 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.2.14 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.2.15 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.2.16 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.2.17 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.2.18 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.2.19 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.2.2 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.2.20 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.2.21 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.2.3 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.2.4 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.2.5 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.2.6 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.2.7 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.2.8 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.2.9 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.3.0 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.3.1 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.3.2 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.3.3 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.3.4 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.3.5 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.3.6 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.3.7 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.4.0 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.4.1 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.4.2 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.4.3 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.4.4 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.4.5 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.5.0 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.5.1 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.5.10 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.11 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.12 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.13 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.14 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.15 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.16 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.17 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.18 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.19 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.2 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.5.20 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.21 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.22 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.23 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.24 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.25 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.26 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.27 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.28 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.29 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.3 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.5.30 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.31 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.32 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.33 conflicts with contao/managed-edition[No version set (p                      arsed as 1.0.0)].
    - contao/core 3.5.4 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.5.5 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.5.6 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.5.7 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.5.8 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - contao/core 3.5.9 conflicts with contao/managed-edition[No version set (pa                      rsed as 1.0.0)].
    - Installation request for contao/managed-edition No version set (parsed as                       1.0.0) -> satisfiable by contao/managed-edition[No version set (parsed as 1.0.0)                      ].
    - Installation request for dklemmt/contao_dk_masonry ^1.2 -> satisfiable by                       dklemmt/contao_dk_masonry[1.2.0, 1.2.1].

[mlwebworker]

Hallo Dirk,

die Installation über Konsole oder Manager funktioniert noch nicht.

Habe die Konsolenausgabe ins alte Ticket geschrieben.

Liebe Grüße und frohe Ostern

Maren

Von: Dirk Klemmt [mailto:notifications@github.com] Gesendet: Montag, 19. März 2018 11:03 An: dklemmt/contao_dk_masonry contao_dk_masonry@noreply.github.com Cc: mlwebworker maren@lange-germany.de; Mention mention@noreply.github.com Betreff: Re: [dklemmt/contao_dk_masonry] Kompatibilität für Contao 4 (#4)

@fritzmg https://github.com/fritzmg vielen Dank für deine Arbeit. Wenn @mlwebworker https://github.com/mlwebworker getestet hat und alles fein ist, merge ich den Code gleich rein

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dklemmt/contao_dk_masonry/issues/4#issuecomment-374159492 , or mute the thread https://github.com/notifications/unsubscribe-auth/ADb49ELpHeIQ4Zp1kuAZ33UlY5PjTzO1ks5tf4JegaJpZM4SnL6Z .

[fritzmg]

Es wurde noch kein neuer Release Tag gemacht. Um die Kompatibilität für Contao 4 testen zu können, musst du folgendes in die composer.json eintragen:

"dklemmt/contao_dk_masonry": "dev-master as 1.2.2"

Dann ein composer update. Wenn alles wie gewünscht funktioniert kannst du das hier im Ticket melden und @dklemmt kann einen relese tag machen.

[mlwebworker]

Die Installation hat soweit funktioniert. Habe aber noch ein Problem mit der Ausgabe von figcaption. Ist mir erst jetzt aufgefallen. In Contao 3.5 wird die figcaption in der Galerie ausgegeben in Contao 4 nicht. Ich habe den Abschnitt für figure auch schon aus der gallery_default.html5 in die masonry_gallery.html5 kopiert. Hat aber nichts geändert. Wahrscheinlich habe ich heute Tomaten auf den Augen.

[fritzmg]

See #8