search

dklemmt / contao_dk_mmenu

Implementation of mmenu as extension for Contao Open Source CMS
15 stars 16 forks source link

update mmenu to 8.3.0, add columns, add polyfill option #40

Closed mirkogleibe closed 5 years ago

mirkogleibe commented 5 years ago

Hey, we needed the new polyfill version included in 8.3.0 to make it work in IE10+. Added an option for that in tl_module cause normally you won't need it, modified the js_mmenu for that and also added an index for css/js files to match encore caching, if used. This doesn't have any effect to the normal loading behavior of this files. Finally the columns addon (https://mmenujs.com/docs/addons/columns.html) was added in basic version, cause we also need it.

Hope everything is fine. If you want some changes, just leave a message.

mirkogleibe commented 5 years ago

all the files of the 8.3.0 update were added.

fritzmg commented 5 years ago

Btw. regarding the polyfills: the documentation says, that you have to manually add two polyfills. Is this not necessary?

mirkogleibe commented 5 years ago

Not really. It worked with the distributed mmenu.polyfills.js file. I compared it with the given files within the _modules folder and everything fits. Seems like it is mentioned cause you're able to compile your own custom versions of those js files. I also checked the mmenu site and didn't find any other than those 2 files, tested incl IE10 and it worked fine.