dklemmt / contao_dk_mmenu

Implementation of mmenu as extension for Contao Open Source CMS
15 stars 16 forks source link

Add itemscope SiteNavigationElement #43

Closed tarun-uwe closed 4 years ago

tarun-uwe commented 4 years ago

Hi together,

while working on a project, where we had an error in our HTML markup, we found an error via w3validator in mmenu extension templates.

The template nav_mmenu.html includes an itemprop attribute. The outer templates don't define an itemscope.

https://validator.w3.org/ and Sistrix mark this as an Error.

On these lines, there should be added the itemscope:

https://github.com/dklemmt/contao_dk_mmenu/blob/3f49fc0f88be06abb4055a3879010170ffcc04a1/src/Resources/contao/templates/mod_mmenu.html5#L3

https://github.com/dklemmt/contao_dk_mmenu/blob/db5cf5900af2341c7b10e612dde8ff1eb7b1e321/src/Resources/contao/templates/mod_mmenuCustom.html5#L3

https://github.com/dklemmt/contao_dk_mmenu/blob/db5cf5900af2341c7b10e612dde8ff1eb7b1e321/src/Resources/contao/templates/mod_mmenuHtml.html5#L2

itemscope itemtype="http://schema.org/SiteNavigationElement"

Best regards Uwe

P.S.: contao core bundle navigation defines it in mod_navigation.html5