search

dklemmt / contao_dk_mmenu

Implementation of mmenu as extension for Contao Open Source CMS
15 stars 16 forks source link

Refactor callbacks + migrations #68

Closed rabauss closed 2 years ago

rabauss commented 2 years ago

For better review I splitted my changes for https://github.com/dklemmt/contao_dk_mmenu/pull/66

In this PR I refactor the callbacks to eventlisteners and the hook to migrations

rabauss commented 2 years ago

@fritzmg thanks for the quick merge. The fix for the missing handling of services with FrameworkAwareInterface is comming with https://github.com/dklemmt/contao_dk_mmenu/pull/69

fritzmg commented 2 years ago

Though I would actually prefer regular dependency injection via constructor instead of the instanceof FrameworkAwareInterface.

rabauss commented 2 years ago

Okay, it's optzimized in #69