search

dklemmt / contao_dk_mmenu

Implementation of mmenu as extension for Contao Open Source CMS
15 stars 16 forks source link

Refactor module options to custom config table #69

Closed rabauss closed 2 years ago

rabauss commented 2 years ago

For better review I splitted my changes for https://github.com/dklemmt/contao_dk_mmenu/pull/66

In this PR I refactor the module options to custom config table. The translations get some optimization, too.

fritzmg commented 2 years ago

@rabauss is this RTM?

rabauss commented 2 years ago

@fritzmg Yes, this config feature should be ready + fixes the framework requirement of #68 !

fritzmg commented 2 years ago

Cool, merged :). Is there any additional work necessary? Otherwise I'd release 4.0.0.

rabauss commented 2 years ago

@fritzmg maybe we could wait until the tests of mmenu v9 for 4.0.0?

fritzmg commented 2 years ago

Alright. Are you actively testing? (I am not)