search

dklemmt / contao_dk_mmenu

Implementation of mmenu as extension for Contao Open Source CMS
15 stars 16 forks source link

Make compatible with PHP 8.1 and CONTAO 5 #71

Closed erikherbert closed 8 months ago

erikherbert commented 2 years ago

Please, can you make it compatible with PHP 8.1 and CONTAO 5

rabauss commented 2 years ago

PHP 8.1 is already unlocked - for contao 5 you may support a developer 💸

erikherbert commented 2 years ago

We had pushed you a working solution! ;-)

rabauss commented 2 years ago

@erikherbert I don't understand - where is the working solution? 🤔

d0p3fish commented 2 years ago

hi @rabauss ,

its in the fork https://github.com/saxony-switzerland-developers/contao_dk_mmenu But this solution is only contao5 compatible, so i didnt create a pull request for the master branch for this.

rabauss commented 2 years ago

@d0p3fish Attention I solved some errors in the migrations in the master branch with #66 Maybe you could rebase your fork when #66 is finally merged ☺️ I think your changes should be compatible with contao 4.13, shouldn't they?

rorych commented 1 year ago

Is the recommended solution to use https://github.com/saxony-switzerland-developers/contao_dk_mmenu or will the original repo also be compatible with contao 5?

fritzmg commented 1 year ago

https://github.com/saxony-switzerland-developers can provide a PR for this repository.

rorych commented 8 months ago

Any chance @erikherbert could create the pull-request for the update and @fritzmg could check and merge the changes? This is a great plugin and it would be a shame, if it would not get updated to Contao 5.

fritzmg commented 8 months ago

Contao 5 compatibility released with 4.1.0 (6cc8509fc718293cb208e2e933ca7366aedfad75).