search

dklollol / Olsen-Framework-Arma-3

MIT License
34 stars 26 forks source link

Improved weather parameters #209

Open brndd opened 5 years ago

brndd commented 5 years ago

The current weather parameters from the env_parameters module don't actually seem to work. This is for numerous reasons:

  1. ACE wind overrides all the setWind etc. settings.
  2. setWindStr works as a multiplier on the total wind speed, same as the sliders in Environment settings do, but what it's actually multiplying is undefined. In practice the old "Violent storm" setting seemed to usually result in wind speeds of like 10 metres per second, which are far from a storm let alone a violent one.
  3. looks like there were only two reasons

I fixed this by making this parameter use the setWind command instead, which sets the wind to an absolute value. I also added a parameter for wind direction. Gusts didn't seem to do anything with setWind so there's no parameter for those.

I also added a parameter to enable/disable the ACE dynamic wind. Disabling it is necessary for the other two parameters to work. If ACE isn't installed in the first place, this parameter shouldn't do anything at all, but it will still show up. Don't know if there's any easy way to change this. This defaults to mission/server default.

setWind should be synced across clients (as per the Bohemia wiki) so this should work. Seemed to work fine on dedi but I could only test it with one player.

The change to start_in_vehicle's CfgFunctions.hpp is because Git wouldn't stop thinking there were modifications to that file until I committed it even though I had a completely fresh clone of the repo. Had something to do with the missing newline or something, I think.

1562647310670 1562651685537

EM-Creations commented 5 years ago

@brndd Would you have any objections to me including this in my fork of the framework?

brndd commented 5 years ago

It's implicitly MIT licensed so feel free to do whatever with it.

EM-Creations commented 4 years ago

Merged into The Bear Cave Framework here: https://github.com/EM-Creations/TheBearCave-Framework-ArmA-3/pull/18