search

dkmfbk / pikes

Pikes is a Knowledge Extraction Suite
GNU General Public License v3.0
23 stars 8 forks source link

Added type restriction support for DBpedia Spotlight #8

Open aleSuglia opened 7 years ago

aleSuglia commented 7 years ago

Hi to all,

I've noticed that you haven't considered the possibility to allow the user to specify type restrictions as it is reported in the official DBpedia Spotlight documentation. For this reason, I've decided to contribute to this project by adding the types parameter to the HTTP request that is used to annotate the text using the DBpedia Spotlight service.

I hope that this pull request is appreciated.

Best regards, Alessandro

ziorufus commented 7 years ago

Dear Alessandro, thank you for your contribution. We are moving some classes (such as the one you patched) to a new project which goal is to become a collection of CoreNLP wrappers made in our institution (FBK). You can see that the classes you modified are already included into the fcw-linking Maven module. If you agree, we'll pull your patch it into that module (by acknowledging you in the commit message). Or, as an alternative, you can ask for a pull request on the new project and I'll accept it immediately.

Best, Alessio

aleSuglia commented 7 years ago

It's a pleasure for me to add new features to your well-structured framework. I will be pleased to add my patch to your new project. I'll clone it in the afternoon and I'll apply the same patch to it as well.

Best regards, Alessandro