dkniffin / activeadmin_reorderable

Adds drag and drop reordering to your ActiveAdmin tables
MIT License
55 stars 22 forks source link

feature Add support for reordering for belongs_to resources #4

Open delphist opened 7 years ago

delphist commented 7 years ago

3

yjukaku commented 6 years ago

I would love to see this merged. However, I think this might be the better way to go?

reorder_url, query_params = active_admin_resource_for(resource.class).route_instance_path(resource).split '?', 2
reorder_url += "/reorder"
reorder_url += "?" + query_params if query_params
span(reorder_handle_content, :class => 'reorder-handle', 'data-reorder-url' => reorder_url)
delphist commented 6 years ago

@yjukaku need to check it, maybe yes – hard to remember where i'm used it to reproduce the bug. Give me some time, please

dkniffin commented 3 years ago

@delphist Any update on whether @yjukaku's suggestion works? Also, would you mind fixing the conflict with master?

dkniffin commented 3 months ago

@delphist is this still valid? If so, can you please rebase to get the new test suite and fix the conflict?